fix(docker): Add GITHUB_API_TOKEN and x-access-token fallbacks for ghcr.io#710
Merged
fix(docker): Add GITHUB_API_TOKEN and x-access-token fallbacks for ghcr.io#710
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…cr.io When authenticating to ghcr.io, add fallback support for: - GITHUB_API_TOKEN as password when GITHUB_TOKEN is not set - x-access-token as username when GITHUB_ACTOR is empty or not set Also fix credential fallback consistency: - Use || instead of ?? for DOCKER_USERNAME/PASSWORD fallback - This ensures empty strings are treated as 'not set' consistently This enables ghcr.io authentication with GitHub App tokens, which use x-access-token as the username. The getsentry/publish workflow uses GITHUB_API_TOKEN for the release bot token, so this fallback allows Docker targets to authenticate to ghcr.io without additional configuration.
BYK
force-pushed
the
fix/ghcr-github-api-token-fallback
branch
from
f557378 to
98ca9e9
Compare
betegon
approved these changes
Jan 13, 2026
This was referenced Jan 13, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add fallback credential support for ghcr.io authentication to work with GitHub App tokens used in the getsentry/publish workflow.
Changes
GITHUB_API_TOKENas a fallback password whenGITHUB_TOKENis not setx-access-tokenas a fallback username whenGITHUB_ACTORis empty or not set||instead of??to also handle empty string valuesFallback Chain for ghcr.io
DOCKER_GHCR_IO_USERNAME/DOCKER_GHCR_IO_PASSWORDGITHUB_ACTOR/GITHUB_TOKENx-access-token/GITHUB_API_TOKEN(new)DOCKER_USERNAME/DOCKER_PASSWORD(existing universal fallback)Related